Skip to content

MultipartDownloader + ObjectDownloader#2

Open
cintiashamsu wants to merge 31 commits intomasterfrom
multipart-downloader
Open

MultipartDownloader + ObjectDownloader#2
cintiashamsu wants to merge 31 commits intomasterfrom
multipart-downloader

Conversation

@cintiashamsu
Copy link
Owner

No description provided.

The strings in the return statement were over the 80 char limit
(1) Set progressThresholds[0] so that I could use array_combine on equal sized arrays
(2) I redefined progressBar in setProgressThresholds after the threshold bar is created. progressBar includes the thresholds as keys and the bar as values
(3) Removed the array_shift in the construct and now that logic is done by displayProgress
(4) Changed assertCount to check for 9 elements instead of 8
(1) testFailedUploadPrintsPartialProgressBar - upload fails at 25% then throws exception
(2) testSetProgressThresholdsThrowsException - checks non-ints
(3) testDisplayProgressThrowsException - checks non-ints
- If config option is true, the total size is sent to upload state and a threshold array is created. DisplayProgress now relies on there being a threshold array, if there is no threshold array (if config = no), nothing prints.
- the progress bar for multipart copy prints halfway for some reason, but the item is still copied (i'll fix this in the next commit)
…d methods)

Works with $config['multipartdownloadtype'] === 'Part' for now since abstract downloader and download state identify parts with their part #. I also need to work on adding to the stream based on ranges/not parts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant